Skip to content
YACReader
Help and support for Windows users.

Issue downloading covers from ComicVine

  • Uutama
  • Topic Author
  • Offline
  • New Member
  • New Member
More
6 years 1 month ago #5393 by Uutama
I'm having a bit of trouble adding the covers from ComicVine to my collection. It is still using my default coverpage and I'm not sure if it even grabs the cover. This is a bit tricky to work with considering some of my books have a couple hundred pages to click through in order to check if it's there or not, but I'm not seeing anything. All of the other metadata scrapes correctly, just not the cover.

Please Log in or Create an account to join the conversation.

More
6 years 1 month ago #5394 by Luis Ángel
Replied by Luis Ángel on topic Issue downloading covers from ComicVine
The cover is not scraped, I guess a setting for doing it makes sense.

Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: www.paypal.com/donate?business=5TAMNQCDD...e=Support+YACReader\

Please Log in or Create an account to join the conversation.

  • Uutama
  • Topic Author
  • Offline
  • New Member
  • New Member
More
6 years 1 month ago #5395 by Uutama
Replied by Uutama on topic Issue downloading covers from ComicVine
Oh, okay. Are you planning on adding that feature to the next build by chance?

Please Log in or Create an account to join the conversation.

More
6 years 1 month ago #5396 by Luis Ángel
Replied by Luis Ángel on topic Issue downloading covers from ComicVine
I can't give you an ETA. The good thing about YACReader is that it is open source and anyone can add this feature :)

Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: www.paypal.com/donate?business=5TAMNQCDD...e=Support+YACReader\

Please Log in or Create an account to join the conversation.

  • Uutama
  • Topic Author
  • Offline
  • New Member
  • New Member
More
6 years 1 month ago #5397 by Uutama
Replied by Uutama on topic Issue downloading covers from ComicVine
Could you point me to the files needed for the scraper?

Please Log in or Create an account to join the conversation.

More
6 years 1 month ago #5398 by selmf
Replied by selmf on topic Issue downloading covers from ComicVine

Uutama wrote: Could you point me to the files needed for the scraper?


Most of the scraper code resides here:

github.com/YACReader/yacreader/tree/deve...erLibrary/comic_vine

There is something Luis forgot to mention though. Our current implementation of the scraper uses a javascript engine called QtScript which has been deprecated for years by upstream and will be removed from the Qt toolkit we use in the upcoming Qt 6 release.

So the first priority for the comic_vine code would be to migrate and refactor the code from using the script engine to a more modern approach.

My answers are not necessarily official YACReader statements but mostly represent my own opinion in technical matters.

Please Log in or Create an account to join the conversation.

More
6 years 1 month ago #5399 by Luis Ángel
Replied by Luis Ángel on topic Issue downloading covers from ComicVine
It's implemented in the `comic_vine*` files.

The info is saved to the DB in this method
Code:
void ComicVineDialog::getComicsInfo(QList<QPair<ComicDB, QString>> &matchingInfo, int count, const QString &publisher)

But at that point I think that you should have the cover before reaching that point, the client is able to get the cover of an issue already but it is only used to identify the volume/comic in the UI.
Code:
void ComicVineClient::getSeriesCover(const QString &url)

I would add a setting somewhere to let the user decide if the cover should be downloaded or not.

Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: www.paypal.com/donate?business=5TAMNQCDD...e=Support+YACReader\

Please Log in or Create an account to join the conversation.

Moderators: Luis Ángel
Powered by Kunena Forum

Thanks for downloading YACReader!

Your download is starting.

YACReader for iOS and Android

Connect to YACReaderLibrary to browse, read remotely and import comics. Your reading progress is synchronized across devices.

Download on the App Store Get it on Google Play Available at Amazon Appstore

Discover all the features on the iOS and Android pages, and learn how to use them in the iOS and Android user guides.

Support YACReader

YACReader for desktop and server is free to use, but it is not free to develop: maintaining this website, developer programs, code signing certificates, test devices and, of course, all the time it takes. Less than 0.01% of downloads end in a donation, so any amount counts.

By supporting the project you help keep it regularly updated and, most importantly, alive. Thanks!