Welcome to the forum, Guest

TOPIC: Issue downloading covers from ComicVine

Issue downloading covers from ComicVine 2 months 3 weeks ago #5393

Uutama

Offline

Fresh Boarder

Posts: 4

Karma: 0

I'm having a bit of trouble adding the covers from ComicVine to my collection. It is still using my default coverpage and I'm not sure if it even grabs the cover. This is a bit tricky to work with considering some of my books have a couple hundred pages to click through in order to check if it's there or not, but I'm not seeing anything. All of the other metadata scrapes correctly, just not the cover.
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5394

Luis Ángel

Offline

Administrator

Posts: 1563

Thank you received: 334

Karma: 30

The cover is not scraped, I guess a setting for doing it makes sense.
Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: t.ly/ODFV
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5395

Uutama

Offline

Fresh Boarder

Posts: 4

Karma: 0

Oh, okay. Are you planning on adding that feature to the next build by chance?
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5396

Luis Ángel

Offline

Administrator

Posts: 1563

Thank you received: 334

Karma: 30

I can't give you an ETA. The good thing about YACReader is that it is open source and anyone can add this feature :)
Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: t.ly/ODFV
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5397

Uutama

Offline

Fresh Boarder

Posts: 4

Karma: 0

Could you point me to the files needed for the scraper?
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5398

selmf

Offline

Developer

Posts: 553

Thank you received: 115

Karma: 11

Uutama wrote:
Could you point me to the files needed for the scraper?

Most of the scraper code resides here:

github.com/YACReader/yacreader/tree/deve...erLibrary/comic_vine

There is something Luis forgot to mention though. Our current implementation of the scraper uses a javascript engine called QtScript which has been deprecated for years by upstream and will be removed from the Qt toolkit we use in the upcoming Qt 6 release.

So the first priority for the comic_vine code would be to migrate and refactor the code from using the script engine to a more modern approach.
My answers are not necessarily official YACReader statements but mostly represent my own opinion in technical matters.
The administrator has disabled public write access.

Issue downloading covers from ComicVine 2 months 3 weeks ago #5399

Luis Ángel

Offline

Administrator

Posts: 1563

Thank you received: 334

Karma: 30

It's implemented in the `comic_vine*` files.

The info is saved to the DB in this method
void ComicVineDialog::getComicsInfo(QList<QPair<ComicDB, QString>> &matchingInfo, int count, const QString &publisher)

But at that point I think that you should have the cover before reaching that point, the client is able to get the cover of an issue already but it is only used to identify the volume/comic in the UI.
void ComicVineClient::getSeriesCover(const QString &url)

I would add a setting somewhere to let the user decide if the cover should be downloaded or not.
Contribute to the project becoming a patron: www.patreon.com/yacreader
You can also donate via Pay-Pal: t.ly/ODFV
The administrator has disabled public write access.
Powered by Kunena Forum